phpunit - Codeception improve readiness unit test -


i'm new test, i'm using codeception , phpunit tdd.

however, methods have lot of code. used best practices ? there way improve readiness of code, can more clean ?

class newsformhandlertest extends \codeception\test\unit {     /**      * @var \unittester      */     protected $tester;      protected function _before()     {     }      protected function _after()     {     }      private function getformmock(){          return $this->getmockbuilder(forminterface::class)             ->disableoriginalconstructor()             ->getmock();     }      private function getnewsmanagermock(){          return $this->getmockbuilder(inewsmanager::class)             ->disableoriginalconstructor()             ->getmock();     }      // tests      public function testshouldhandleasuccessfulformsubmissionforaddanews()     {          // prepare         $request = new \symfony\component\httpfoundation\request();         $news = new news();          $form = $this->getformmock();         $form->expects($this->once())             ->method('isvalid')             ->will($this->returnvalue(true));          $form->expects($this->once())             ->method('submit');          $form->expects($this->once())             ->method('getdata')             ->will($this->returnvalue($news));          $newsmanager = $this->getnewsmanagermock();         $newsmanager->expects($this->once())             ->method('add');          $user = stub::make(webserviceuser::class, []);          // test         $handler = new newsformhandler($newsmanager, $user);         $newsreturned = $handler->handle($form, $request, newsformhandler::add);          // assert         $this->assertinstanceof(news::class, $newsreturned);         $this->assertequals($news, $newsreturned);      }      public function testshouldhandleasuccessfulformsubmissionforeditanews()     {          // prepare         $request = new \symfony\component\httpfoundation\request();         $news = new news();          $form = $this->getformmock();         $form->expects($this->once())             ->method('isvalid')             ->will($this->returnvalue(true));          $form->expects($this->once())             ->method('submit');          $form->expects($this->once())             ->method('getdata')             ->will($this->returnvalue($news));          $newsmanager = $this->getnewsmanagermock();         $newsmanager->expects($this->once())             ->method('edit');          $user = stub::make(webserviceuser::class, []);          // test         $handler = new newsformhandler($newsmanager, $user);         $newsreturned = $handler->handle($form, $request, newsformhandler::edit);          // assert         $this->assertinstanceof(news::class, $newsreturned);         $this->assertequals($news, $newsreturned);      }      public function testfailformwithinvaliddata()     {          // prepare         $request = new \symfony\component\httpfoundation\request();          $form = $this->getformmock();         $form->expects($this->once())             ->method('isvalid')             ->will($this->returnvalue(false));           $newsmanager = $this->getnewsmanagermock();         $newsmanager->expects($this->never())             ->method('edit');          $this->expectexception(invalidformexception::class);          $user = stub::make(webserviceuser::class, []);          // test         $handler = new newsformhandler($newsmanager, $user);         $newsreturned = $handler->handle($form, $request, newsformhandler::add);          // assert         $this->assertnull($newsreturned);      }    }

  1. you can extract body of testshouldhandleasuccessfulformsubmissionforaddanews , testshouldhandleasuccessfulformsubmissionforeditanews other method parameter $action = 'add'|'edit' (or use defined contants newsformhandler::edit etc), they're same.

  2. you can extract mock creation above methods single parametrized method, process same (pass differences method arguments , let dirty work).

  3. you can add readability using bdd style, in example in page http://codeception.com/docs/05-unittests#bdd-specification-testing


Comments

Post a Comment

Popular posts from this blog

php - How to add and update images or image url in Volusion using Volusion API -

actually have store importing products store product data insert , update image or image url not insert , update. this xml code name datapro.txt. <products_joined> <productcode>3710_012t</productcode> <vendor_partno>eah5450silent/di/1gd3(lp)</vendor_partno> <productname>test product ta</productname> <hideproduct>n</hideproduct> <stockstatus>20</stockstatus> <lastmodified>1/5/2016 10:25:00 am</lastmodified> <lastmodby>2</lastmodby> <productweight>0.9</productweight> <productprice>100</productprice> <productmanufacturer>asus tek</productmanufacturer> <vendor_price>32.69</vendor_price> <numproductssharingstock>0</numproductssharingstock> <categoryids>107</categoryids> <producturl>http://tebkq.mvlce.servertrust.com/productdetails.asp?productcode=3710_012t</producturl...
Read more

Laravel mail error `Swift_TransportException in StreamBuffer.php line 269: Connection could not be established with host smtp.gmail.com [ #0]` -

i developing website contact-us page guest users can send me email using gmail . anytime try send mail using contact-us form, error swift_transportexception in streambuffer.php line 269: connection not established host smtp.gmail.com [ #0] this mail.php return [ 'driver' => env('mail_driver', 'smtp'), 'host' => env('mail_host', 'smtp.gmail.com'), 'port' => 587, 'from' => ['address' => '', 'name' => ''], 'encryption' => env('mail_encryption', 'tls'), 'username' => env('mail_username'), 'password' => env(mail_password), 'sendmail' => '/usr/sbin/sendmail -bs', 'pretend' => env('mail_pretend', false), ]; this .env mail_driver=smtp mail_host=smtp.gmail.com mail_port=587 mail_username=afecjaped@gmail.com mail_password=********...
Read more

c# SetCompatibleTextRenderingDefault must be called before the first -

i tried search exception couldn't find solution on case i'am using code below invoke .net application : assembly assem = assembly.load(data); methodinfo method = assem.entrypoint; var o = activator.createinstance(method.declaringtype); method.invoke(o, null); the application invoked has form , in entrypoint of application : [stathread] static void main() { application.enablevisualstyles(); application.setcompatibletextrenderingdefault(false); //exception application.run(new form1()); } setcompatibletextrenderingdefault must called before first iwin32window object created in application. edit : assembly = assembly.load(data); methodinfo method = a.gettype().getmethod("start"); var o = activator.createinstance(method.declaringtype); method.invoke(o, null); you should create new method skips initialization...
Read more