php - Passing $_POST to Db Class Without any Processing -


i trying pass $_post global variable directly database through mysqli_real_escape_string without processing...

here code working fine.

  1. what possible problem arising due type of coding?
  2. what security risks?
  3. is shortcut or there still more...???
class db{ ... more ...      public function insert($args=array()){         if(!isset($args['table']) || !isset($args['values'])){             return false;         }         $table=$args['table'];         $values=$this->process_insert($args['values']);         $query="insert {$table} {$values}";         $result=$this->query2db($query); //method returns mysqli_query()         if($result){             return true;         }else{             return false;         }     }      protected function process_insert($data=array()){         $values="";         $fields="";         $glue=", ";         if(isset($data)){             foreach($data $key=> $value){                 $key=$this->escape($key);                 $value=$this->escape($value); //method returns mysqli_real_escape_string                 $fields .="{$key}".$glue;                 $values .="'{$value}'".$glue;             }             $fields=rtrim($fields, $glue);             $values=rtrim($values, $glue);             return "({$fields}) values ({$values})";         }else{             return false;         }     }  ... more ... }  if(!empty($_post)){      $query=array(     'table'=>'users',     'values'=> $_post //<=== problem here     );      $dbobj=new db;     $dbobj->insert($query);  } 

update-

  • i can use interactions android...
  • auto generate form having values in array format
  • and validating using array

instead of using mysql_real_escape_string, suggest using prepared statements. say, never trust users input. data escaped still gets in database , not forget performance boost using prepared statements!

read post mysql_real_escape_string vs prepared statements


Comments

Popular posts from this blog

php - How to add and update images or image url in Volusion using Volusion API -

javascript - IE9 error '$'is not defined -