python - Isn't using eval() with a dictionary a better way in this case? -


the 2 functions below perform arithmetic operation on 2 integers , return integer result.

i've heard lot eval() being bad use because can cause many problems. taking @ code i've written below, seems eval() spares many lines of code, right?

def dict_calculate(operation, num1, num2):     operations = {'add': '+', 'subtract': '-', 'multiply': '*', 'divide': '//'}     return eval(str(num1) + operations[operation] + str(num2))  def conditional_calculate(operation, num1, num2):     if operation == 'add':         return num1 + num2     if operation == 'subtract':         return num1 - num2     if operation == 'multiply':         return num1 * num2     if operation == 'divide':         return num1 // num2  if __name__ == "__main__":     x = 10     y = 5      print(str(dict_calculate('add', x, y)) + ', ', end='')     print(str(dict_calculate('subtract', x, y)) + ', ', end='')     print(str(dict_calculate('multiply', x, y)) + ', ', end='')     print(str(dict_calculate('divide', x, y)))      print(str(conditional_calculate('add', x, y)) + ', ', end='')     print(str(conditional_calculate('subtract', x, y)) + ', ', end='')     print(str(conditional_calculate('multiply', x, y)) + ', ', end='')     print(str(conditional_calculate('divide', x, y)))

outputs same both functions

15, 5, 50, 2 15, 5, 50, 2

isn't eval best use in type of case? if not, there better way eval() achieve same type of code-efficiency?

thanks lot.

you can this:

import operator def dict_calculate(operation, num1, num2):     operations = {'add': operator.add,                   'subtract': operator.sub,                   'multiply': operator.mul,                   'divide': operator.floordiv}     return operations[operation](num1, num2)

if don't want import module, can this:

def dict_calculate(operation, num1, num2):     operations = {'add': '__add__',                   'subtract': '__sub__',                   'multiply': '__mul__',                   'divide': '__floordiv__'}     return getattr(num1, operations[operation])(num2)

Comments

Post a Comment

Popular posts from this blog

php - How to add and update images or image url in Volusion using Volusion API -

actually have store importing products store product data insert , update image or image url not insert , update. this xml code name datapro.txt. <products_joined> <productcode>3710_012t</productcode> <vendor_partno>eah5450silent/di/1gd3(lp)</vendor_partno> <productname>test product ta</productname> <hideproduct>n</hideproduct> <stockstatus>20</stockstatus> <lastmodified>1/5/2016 10:25:00 am</lastmodified> <lastmodby>2</lastmodby> <productweight>0.9</productweight> <productprice>100</productprice> <productmanufacturer>asus tek</productmanufacturer> <vendor_price>32.69</vendor_price> <numproductssharingstock>0</numproductssharingstock> <categoryids>107</categoryids> <producturl>http://tebkq.mvlce.servertrust.com/productdetails.asp?productcode=3710_012t</producturl...
Read more

Laravel mail error `Swift_TransportException in StreamBuffer.php line 269: Connection could not be established with host smtp.gmail.com [ #0]` -

i developing website contact-us page guest users can send me email using gmail . anytime try send mail using contact-us form, error swift_transportexception in streambuffer.php line 269: connection not established host smtp.gmail.com [ #0] this mail.php return [ 'driver' => env('mail_driver', 'smtp'), 'host' => env('mail_host', 'smtp.gmail.com'), 'port' => 587, 'from' => ['address' => '', 'name' => ''], 'encryption' => env('mail_encryption', 'tls'), 'username' => env('mail_username'), 'password' => env(mail_password), 'sendmail' => '/usr/sbin/sendmail -bs', 'pretend' => env('mail_pretend', false), ]; this .env mail_driver=smtp mail_host=smtp.gmail.com mail_port=587 mail_username=afecjaped@gmail.com mail_password=********...
Read more

c# SetCompatibleTextRenderingDefault must be called before the first -

i tried search exception couldn't find solution on case i'am using code below invoke .net application : assembly assem = assembly.load(data); methodinfo method = assem.entrypoint; var o = activator.createinstance(method.declaringtype); method.invoke(o, null); the application invoked has form , in entrypoint of application : [stathread] static void main() { application.enablevisualstyles(); application.setcompatibletextrenderingdefault(false); //exception application.run(new form1()); } setcompatibletextrenderingdefault must called before first iwin32window object created in application. edit : assembly = assembly.load(data); methodinfo method = a.gettype().getmethod("start"); var o = activator.createinstance(method.declaringtype); method.invoke(o, null); you should create new method skips initialization...
Read more